Commit Graph

23 Commits

Author SHA1 Message Date
Guillermo Rauch
bc178a5228 It now works before dom is ready :) 2012-03-01 19:53:51 -03:00
Guillermo Rauch
110765dbc1 Misc refactoring.
- Switched to `hashchange` listening instead of delegation
  We still check that the given hash exists as a `href` within a valid
  Skeleton tabs markup, but you can now send links around that focus
  on tabs.

  As an example, if I tweet out mypage.com/#activetab, it will check that
  `#activetab` is a valid href in an anchor within an `<ul class="tabs">`
  element, and if so, make that tab active.

- In addition, you can have multiple anchors in the page that
  trigger tabs by simply setting the appropriate `href`.

- Leverage `closest` and `find` instead of `parent`, `siblings` and
  `children` (code simplification).
2012-03-01 19:38:50 -03:00
Guillermo Rauch
4c7d6b0b3e Don't assume $ is jQuery. Rely on jQuery global instead. 2012-03-01 19:33:42 -03:00
Guillermo Rauch
6da48f64c3 Switched to 2-space indentation. 2012-03-01 19:32:51 -03:00
Guillermo Rauch
17f0141da9 JSDoc-compatible comment formatting. 2012-03-01 19:30:57 -03:00
Guillermo Rauch
d72703e77a Clear whitespace. 2012-03-01 19:30:17 -03:00
Scott Rabin
aeaf1b4bb7 Changed .delegate to .on for future compatibility with jQuery 2012-01-26 00:39:23 -05:00
Dave Gamache
94062ea1d3 fixing 768 alpha omega bug, changing the button css to clean it up a bit and resetting version on tabs 2012-01-25 21:27:50 -08:00
Dave Gamache
b43be292ee changing to lastest jQuery version and using new tabs js 2012-01-25 20:51:32 -08:00
Dave Gamache
751c738bbe reverting to old tabs.js because others don't function correctly in IE8- 2011-08-17 22:11:39 -07:00
Dave Gamache
0ed1e6e1ed updaing docs and commenting all the CSS in correctly 2011-08-17 21:58:20 -07:00
Dave Gamache
f53e666531 removing jquery (only using Google CDN now); refactoring layout.css media queries to be more straightforward and better commented; Fixed tabs for CSS to use first-child so it would have all the borders even in IE 2011-08-17 21:05:28 -07:00
Dave Gamache
5e668f243b adding the actual tabs.js file 2011-08-17 18:37:35 -07:00
Dave Gamache
a853af7018 fixing the app.js to become tabs.js and refactoring based on some awesome input from napcs on github 2011-08-17 18:37:22 -07:00
Dave Gamache
19b1921a6c made changed to remove issue where browser cannot zoom/scale 2011-07-17 12:28:18 -07:00
James Aitken
8b05d2bb35 Add active class to the currently active tab content, as well as the tab itself
If this is not done, then the active class remains on the tab that was initially visible on page load - even if this tab is now hidden and no longer active. This is confusing when trying to target CSS as a the selector "ul.tabs-content > li.active" , may not be visible.

Also removed unused tabsContent variable.
2011-06-08 13:42:36 +01:00
Dave Gamache
c1ad114a99 moved version to 1.0.2 with change of CSS 2011-05-20 09:39:44 -07:00
Dave Gamache
941a324339 moving up to version 1.0.1 and making some slight changes in the CSS 2011-05-19 12:05:30 -07:00
Dave Gamache
3b9fe7c444 Add Apple Touch Icon sizes and linked those in, added active button CSS, changed some unneeded CSS in base.css, changed the Favicon to be square and cleaner, updated the app.js to include awesome suggestions made from Github community to be faster. Honestly, shocked at how awesome Github community has been already and thanks so much to everyone for the help 2011-05-17 17:54:18 -07:00
Paul Irish
6f643a6761 fixing some weird stuff in the app.js 2011-05-16 18:03:36 -07:00
Dave Gamache
44f4156977 changed Skeleton.gs to skeleton or getskeleton.com and cleaned up some last pieces 2011-05-15 17:02:52 -07:00
Dave Gamache
6276c745f8 recleaned all of the code and formatting to be BEAUTIFUL 2011-05-15 16:50:51 -07:00
Dave Gamache
82c35f64b7 changed the git repo to the src folder, browser tested, changed the tabs to work cross browser and to stack...removed the IE conditional stylesheet 2011-05-15 16:13:52 -07:00