Commit Graph

82 Commits

Author SHA1 Message Date
Dave Gamache
94ce27001d Merge pull request #71 from LearnBoost/tabs-refactor
Tabs refactor
2012-03-03 12:17:14 -08:00
Guillermo Rauch
bc178a5228 It now works before dom is ready :) 2012-03-01 19:53:51 -03:00
Guillermo Rauch
110765dbc1 Misc refactoring.
- Switched to `hashchange` listening instead of delegation
  We still check that the given hash exists as a `href` within a valid
  Skeleton tabs markup, but you can now send links around that focus
  on tabs.

  As an example, if I tweet out mypage.com/#activetab, it will check that
  `#activetab` is a valid href in an anchor within an `<ul class="tabs">`
  element, and if so, make that tab active.

- In addition, you can have multiple anchors in the page that
  trigger tabs by simply setting the appropriate `href`.

- Leverage `closest` and `find` instead of `parent`, `siblings` and
  `children` (code simplification).
2012-03-01 19:38:50 -03:00
Guillermo Rauch
4c7d6b0b3e Don't assume $ is jQuery. Rely on jQuery global instead. 2012-03-01 19:33:42 -03:00
Guillermo Rauch
6da48f64c3 Switched to 2-space indentation. 2012-03-01 19:32:51 -03:00
Guillermo Rauch
17f0141da9 JSDoc-compatible comment formatting. 2012-03-01 19:30:57 -03:00
Guillermo Rauch
d72703e77a Clear whitespace. 2012-03-01 19:30:17 -03:00
Dave Gamache
a05d0c7317 Merge pull request #70 from 46Bit/patch-1
Padding Bug on Offset-by-eight
2012-02-28 09:27:39 -08:00
Michael Mokrysz
8a719ccff0 Fixed what seems to be a numerical mistake. 336 + 48 = 384 but is given as 348. 2012-02-25 00:54:51 +00:00
Dave Gamache
b7ae333d07 adding some amazing -moz CSS from the @necolas 2012-01-26 21:55:15 -08:00
Dave Gamache
d34cdf66bb changing line-height to normal for buttons 2012-01-25 22:30:01 -08:00
Dave Gamache
d0903383d3 Merge pull request #62 from scottrabin/delegate-on
Changed .delegate to .on for future compatibility with jQuery
2012-01-25 21:49:12 -08:00
Scott Rabin
aeaf1b4bb7 Changed .delegate to .on for future compatibility with jQuery 2012-01-26 00:39:23 -05:00
Dave Gamache
d6835b91a6 moving the html5 shim link to below CSS 2012-01-25 21:38:24 -08:00
Dave Gamache
94062ea1d3 fixing 768 alpha omega bug, changing the button css to clean it up a bit and resetting version on tabs 2012-01-25 21:27:50 -08:00
Dave Gamache
057c8d617f Merge branch 'master' of github.com:dhgamache/Skeleton 2012-01-25 21:04:02 -08:00
Dave Gamache
cd25dd9818 Merge pull request #53 from jokull/master
Scoped selectors are better
2012-01-25 21:03:48 -08:00
Dave Gamache
78ae309e2f adding column and columns, singular and plural, to single column 2012-01-25 21:01:54 -08:00
Dave Gamache
b43be292ee changing to lastest jQuery version and using new tabs js 2012-01-25 20:51:32 -08:00
Jökull Sólberg Auðunsson
c3bd1eb457 Scope the .column and .columns selectors correctly. 2011-11-29 17:40:44 +00:00
Dave Gamache
2dfa28cea9 relinking from jQuery hotlink cause Google CDN delivery was wonky on local 2011-09-17 10:30:18 -07:00
Dave Gamache
3f12a6877e fixing the button background inheritance issue 2011-09-08 22:49:38 -07:00
Dave Gamache
20e1874b96 changing active button styles 2011-08-17 23:22:43 -07:00
Dave Gamache
0222ed0975 changing the version numbers where needed 2011-08-17 22:22:11 -07:00
Dave Gamache
751c738bbe reverting to old tabs.js because others don't function correctly in IE8- 2011-08-17 22:11:39 -07:00
Dave Gamache
0ed1e6e1ed updaing docs and commenting all the CSS in correctly 2011-08-17 21:58:20 -07:00
Dave Gamache
68fb0e1755 resolving a CSS typo 2011-08-17 21:34:24 -07:00
Dave Gamache
9e4f68e180 removing some of the type=text/javascript since it is the default 2011-08-17 21:06:51 -07:00
Dave Gamache
f53e666531 removing jquery (only using Google CDN now); refactoring layout.css media queries to be more straightforward and better commented; Fixed tabs for CSS to use first-child so it would have all the borders even in IE 2011-08-17 21:05:28 -07:00
Dave Gamache
5e668f243b adding the actual tabs.js file 2011-08-17 18:37:35 -07:00
Dave Gamache
a853af7018 fixing the app.js to become tabs.js and refactoring based on some awesome input from napcs on github 2011-08-17 18:37:22 -07:00
Dave Gamache
a06ce03310 Merge pull request #34 from tzilliox/master
Add slashes on the self closing <link> tags.
2011-08-08 17:20:14 -07:00
Thomas ZILLIOX
f8b68e3b8b Add slashes on the self closing <link> tags. 2011-08-08 16:49:55 +03:00
Dave Gamache
cc6c5090c0 Merge pull request #28 from denisjacquemin/master
Offset values fix for Tablet (Portrait) and better indenting!
2011-07-25 22:32:50 -07:00
Denis Jacquemin
1460abb9da Offsets values fix for #Tablet (Portrait) 2011-07-24 16:49:19 +02:00
Denis Jacquemin
ba19b256d8 indentation cleanup 2011-07-24 16:47:07 +02:00
Dave Gamache
19b1921a6c made changed to remove issue where browser cannot zoom/scale 2011-07-17 12:28:18 -07:00
Dave Gamache
b61c4b890f Merge pull request #17 from LoonyPandora/master
Add active class to the currently active tab-content.
2011-06-12 10:07:03 -07:00
James Aitken
8b05d2bb35 Add active class to the currently active tab content, as well as the tab itself
If this is not done, then the active class remains on the tab that was initially visible on page load - even if this tab is now hidden and no longer active. This is confusing when trying to target CSS as a the selector "ul.tabs-content > li.active" , may not be visible.

Also removed unused tabsContent variable.
2011-06-08 13:42:36 +01:00
Dave Gamache
0eed0f8949 added the img.scale-with-grid class to allow people to select images that should size with the grid 2011-06-06 20:25:33 -07:00
Dave Gamache
c65cc2c982 fixed the 20px issue on the bottom of the page 2011-05-30 10:56:29 -07:00
Dave Gamache
c7f3e545a0 a couple quick updates to the CSS and denoted that it was version 1.0.2 2011-05-29 09:46:46 -07:00
Dave Gamache
6b8ff4d489 changed the list statement to include a needed comma - thanks to 2csswizardry 2011-05-23 14:15:57 -07:00
Dave Gamache
e59637c5f0 edited the doc head of 404 to match the regular homepage 2011-05-22 10:18:32 -07:00
Dave Gamache
42354329ef updated the 404 page to be the same as the regular index page 2011-05-22 10:17:31 -07:00
dhgamache
8ce37ba4b4 Merge pull request #11 from valentinvieriu/patch-1
Favicon for 404 incorrectly linked!
2011-05-22 10:16:20 -07:00
valentinvieriu
ae0a8dcf82 I think the href for the favicon is wrong. 2011-05-21 12:33:06 -07:00
Dave Gamache
41912bd47d changed the image commenting in base.css to be more clear 2011-05-20 17:18:42 -07:00
Dave Gamache
df67c35228 removed the img width 100% declaration. Breaks some plugins and techniques, but commented why it was removed and how the same effect of scaling images can be achieved by individually calling those properties on images 2011-05-20 15:30:44 -07:00
Dave Gamache
c1ad114a99 moved version to 1.0.2 with change of CSS 2011-05-20 09:39:44 -07:00