Fixing ansible-lint errors

playbooks/base.yml

@@ -2,28 +2,28 @@
 
 - name: Uninstall Puppet/OpenVox packages
   hosts: all
-  become: yes
+  become: true
   tasks:
     - name: Uninstall puppet package
-      package:
+      ansible.builtin.package:
         name: 'puppet-agent'
         state: absent
     - name: Uninstall puppet-release package
-      package:
+      ansible.builtin.package:
         name: 'puppet8-release'
         state: absent
     - name: Uninstall openvox package
-      package:
+      ansible.builtin.package:
         name: 'openvox-agent'
         state: absent
     - name: Uninstall openvox-release package
-      package:
+      ansible.builtin.package:
         name: 'openvox8-release'
         state: absent
 
 - name: Disable Puppet Service if present
   hosts: all
-  become: yes
+  become: true
   tasks:
     - name: Check if Puppet service exists
       ansible.builtin.service_facts:
@@ -32,5 +32,5 @@
       ansible.builtin.service:
         name: puppet
         state: stopped
-        enabled: False
+        enabled: false
       when: "'puppet.service' in services or 'puppet' in services"

playbooks/os_patching.yml

@@ -11,22 +11,22 @@
   tasks:
     - name: Update apt cache (Debian)
       ansible.builtin.apt:
-        update_cache: yes
+        update_cache: true
         cache_valid_time: 3600
       when: ansible_os_family == "Debian"
 
     - name: Upgrade all packages (Debian)
       ansible.builtin.apt:
         upgrade: dist
-        autoremove: yes
-        autoclean: yes
+        autoremove: true
+        autoclean: true
       when: ansible_os_family == "Debian"
 
-    - name: Upgrade all packages (RedHat)
+    - name: Upgrade all packages (RedHat) # noqa: package-latest
       ansible.builtin.dnf:
         name: "*"
         state: latest
-        update_cache: yes
+        update_cache: true
       when: ansible_os_family == "RedHat"
 
     - name: Check if reboot is required (Debian)

playbooks/packages.yml

@@ -1,17 +1,15 @@
 ---
 
-- hosts: all
-  become: True
+- name: Install common packages
+  hosts: all
+  become: true
   tasks:
     - name: Install common packages on all hosts
-      package:
+      ansible.builtin.package:
         name: "{{ packages_common }}"
         state: present
 
-- hosts: all
-  become: True
-  tasks:
     - name: Install extra packages if listed
-      package:
+      ansible.builtin.package:
         name: "{{ packages_extra | default([]) }}"
         state: present