Fixed a logic error with removing benchmarks from a test; cleaned up some linter errors

src/models/test.rb

@@ -7,7 +7,7 @@ class Test < Sequel::Model
   many_to_one :hardware
   many_to_many :benchmarks
 
-  def has_benchmark(benchmark_id)
+  def benchmark?(benchmark_id)
     return benchmarks_dataset.where(Sequel[:benchmarks][:id] => benchmark_id).any?
   end
 

src/routes/test.rb

@@ -69,19 +69,16 @@ class GameData < Sinatra::Base
       description: params[:test_description]
     )
 
-    # create an array of the selected benchmarks
     selected_benchmarks = Array(params[:test_benchmarks])
+
     # remove benchmarks no longer associated with the test
-    tst.benchmarks.each do |b|
+    tst.benchmarks.dup.each do |b|
-      if not selected_benchmarks.include?(b)
+      tst.remove_benchmark(b.id) unless selected_benchmarks.include?(b.id)
-        tst.remove_benchmark(b)
-      end
     end
+
     # associate the benchmarks to the test
     selected_benchmarks.each do |b|
-      if not tst.has_benchmark(b)
+      tst.add_benchmark(b) unless tst.benchmark?(b)
-        tst.add_benchmark(b)
-      end
     end
 
     redirect "/test/#{tst.id}"

views/test/edit.erb

@@ -28,7 +28,7 @@
         <label for="test_benchmarks">Benchmarks</label>
         <select id="test_benchmarks" class="form-select" name="test_benchmarks[]" multiple>
           <% for b in benchmarks %>
-            <option value="<%= b.id %>" <% if test.has_benchmark(b.id) %>selected<% end %>><%= b.name %></option>
+            <option value="<%= b.id %>" <% if test.benchmark?(b.id) %>selected<% end %>><%= b.name %></option>
             <% end %>
         </select>
       </div>