BitGoblin/dragoon
1
0
Fork 0
Code Issues 7 Pull Requests Projects Releases 16 Wiki Activity

Streamlined the ffmpeg ProcessBuilder to inherit IO streams; added printing out of the ffmpeg command to verify it's working as intended.

Browse Source
This commit is contained in:
Gregory Ballantine 2022-05-01 13:49:41 -04:00
parent 898d1467c0
commit 6640f2d5c4
1 changed files with 6 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
src/main/java/tech/bitgoblin/video/Transcoder.java
View File

@ -45,9 +45,10 @@ public class Transcoder {
String filename = Paths.get(filePath).getFileName().toString(); String filename = Paths.get(filePath).getFileName().toString();
String outputPath = Paths.get(this.repo_dir, "output", String.format("%s.mov", filename)).toString(); String outputPath = Paths.get(this.repo_dir, "output", String.format("%s.mov", filename)).toString();
String cmd = String.format("%s -i %s -c:v %s -vf \"%s\" -profile:v %s -c:a %s %s", String cmd = String.format("%s -i %s -y -f %s -c:v %s -vf %s -profile:v %s -c:a %s %s",
this.ffmpeg_path, // FFMPEG binary path this.ffmpeg_path, // FFMPEG binary path
f.toString(), // input file f.toString(), // input file
"mov",
"dnxhd", // video codec "dnxhd", // video codec
"scale=1920x1080,fps=60,format=yuv422p", // video format "scale=1920x1080,fps=60,format=yuv422p", // video format
"dnxhr_hq", // video profile "dnxhr_hq", // video profile
@ -56,12 +57,13 @@ public class Transcoder {
); );
ProcessBuilder pb = new ProcessBuilder(cmd.split("\\s+")); ProcessBuilder pb = new ProcessBuilder(cmd.split("\\s+"));
pb.redirectErrorStream(true); pb.inheritIO(); // use the java processes' input and output streams
pb.redirectOutput(ProcessBuilder.Redirect.PIPE);
try { try {
Process process = pb.start(); Process process = pb.start();
int ret = process.waitFor(); int ret = process.waitFor();
System.out.printf("Program exited with code: %d", ret); System.out.printf("Program exited with code: %d\n", ret);
System.out.println(String.join(" ", pb.command()));
System.out.println();
} catch (IOException | InterruptedException e) { } catch (IOException | InterruptedException e) {
throw new RuntimeException(e); throw new RuntimeException(e);
} }
@ -82,21 +84,4 @@ public class Transcoder {
IOUtils.createDirectory(Paths.get(this.repo_dir, "output").toString()); IOUtils.createDirectory(Paths.get(this.repo_dir, "output").toString());
} }
// Stream handler class for the Transcoder
private static class StreamGobbler implements Runnable {
private InputStream inputStream;
private Consumer<String> consumer;
public StreamGobbler(InputStream inputStream, Consumer<String> consumer) {
this.inputStream = inputStream;
this.consumer = consumer;
}
@Override
public void run() {
new BufferedReader(new InputStreamReader(inputStream)).lines().forEach(consumer);
}
}
} }