From 0510c80c344e404459a175f188016bc7399f5388 Mon Sep 17 00:00:00 2001
From: Gregory Ballantine <gballantine@bitgoblin.tech>
Date: Mon, 3 Jun 2024 11:28:24 -0400
Subject: [PATCH] Reworked test view page

---
 src/Models/Test.php  | 18 +++++++++++++++
 views/test/view.twig | 55 ++++++++++++++++++--------------------------
 2 files changed, 41 insertions(+), 32 deletions(-)

diff --git a/src/Models/Test.php b/src/Models/Test.php
index 493db8d..68acd3d 100644
--- a/src/Models/Test.php
+++ b/src/Models/Test.php
@@ -24,4 +24,22 @@ class Test extends Model {
     return $this->belongsTo(Component::class);
   }
 
+  public function benchmarkResults() {
+    $data = [];
+
+    foreach ($this->benchmarks as $i, $b) {
+      $benchmarkResults = $this->results()->where('benchmark_id', $b->id)->get();
+      $data[$i] = [
+        'name'    => $b->name,
+        'scoring' => $b->scoring,
+        'count'   => count($benchmarkResults),
+        'average' => 0,
+        'minimum' => 0,
+        'maximum' => 0,
+      ]
+    }
+
+    return $data;
+  }
+
 }
diff --git a/views/test/view.twig b/views/test/view.twig
index 3ef914d..fa2a831 100644
--- a/views/test/view.twig
+++ b/views/test/view.twig
@@ -7,11 +7,6 @@
     <div class="twelve columns">
       <h1>{{ test.title }}</h1>
       <p>{{ test.description }}</p>
-      <ul>
-        {% for b in test.benchmarks %}
-          <li>{{ b.name }}</li>
-        {% endfor %}
-      </ul>
     </div>
   </div>
 
@@ -54,36 +49,32 @@
 
   <div class="row">
     <div class="twelve columns">
-      <h3>Test results:</h3>
+      <h3>Benchmark results:</h3>
 
-      {% if test.results | length > 0 %}
-        <table class="u-full-width">
-          <thead>
+      <table class="u-full-width">
+        <thead>
+          <tr>
+            <th>Benchmark</th>
+            <th>Scoring</th>
+            <th># Results</th>
+            <th>Avg.</th>
+            <th>Min.</th>
+            <th>Max.</th>
+          </tr>
+        </thead>
+        <tbody>
+          {% for r in test.benchmarkResults() %}
             <tr>
-              <th>Component</th>
-              <th>Benchmark</th>
-              <th>Scoring</th>
-              <th>Avg.</th>
-              <th>Min.</th>
-              <th>Max.</th>
+              <td>{{ r.name }}</td>
+              <td>{{ r.scoring | capitalize }}</td>
+              <td>{{ r.count }}</td>
+              <td>{{ r.average }}</td>
+              <td>{{ r.minimum ? r.minimum : 'N/a' }}</td>
+              <td>{{ r.maximum ? r.maximum : 'N/a' }}</td>
             </tr>
-          </thead>
-          <tbody>
-            {% for r in test.results %}
-              <tr>
-                <td>{{ test.component.name }}</td>
-                <td>{{ r.benchmark.name }}</td>
-                <td>{{ r.benchmark.scoring | capitalize }}</td>
-                <td>{{ r.average }}</td>
-                <td>{{ r.minimum ? r.minimum : 'N/a' }}</td>
-                <td>{{ r.maximum ? r.maximum : 'N/a' }}</td>
-              </tr>
-            {% endfor %}
-          </tbody>
-        </table>
-      {% else %}
-        <p>There are no results associated with this test.</p>
-      {% endif %}
+          {% endfor %}
+        </tbody>
+      </table>
     </div>
   </div>
 {% endblock %}