BitGoblin/Bones
1
0
Fork 0
Code Issues 5 Pull Requests Packages Projects Releases Wiki Activity

Removed the 'hack' that made IE work, forced the handler to be called in the proper context.

Browse Source
This commit is contained in:
Eric Kever 2011-07-21 09:11:42 -07:00
parent 60fd933834
commit 7afa4d85d0
1 changed files with 8 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
javascripts/app.js
View File

@ -70,17 +70,15 @@ function removeClass(element, name){
} }
function doFancyExpensiveTabThings(){ function doFancyExpensiveTabThings(){
var tabs = (document.getElementsByClassName ? document.getElementsByClassName("tabs") : getElementsByClassName(document, "ul", "tabs")); var tabs = getElementsByClassName(document, "ul", "tabs");
for(var i = 0, j = tabs.length; i < j; i++){ for(var i = 0, j = tabs.length; i < j; i++){
var tabList = tabs[i].getElementsByTagName('li'); var tabList = tabs[i].getElementsByTagName('li');
for(var k = 0, l = tabList.length; k < l; k++){ for(var k = 0, l = tabList.length; k < l; k++){
(function(){ //Need this because the click handler isn't called with the proper context in IE7/8. tabList[k].getElementsByTagName('a')[0][BIND_HANDLER](BIND_HANDLER_PREFIX + "click", function(e){
var tab = tabList[k].getElementsByTagName('a')[0]; var event = e || window.event;
return (function(e){
tab[BIND_HANDLER](BIND_HANDLER_PREFIX + "click", function(e){ var contentLocation = this.href.substr(this.href.indexOf("#")) + "Tab",
var contentLocation = tab.href.substr(tab.href.indexOf("#")) + "Tab",
event = e || window.event,
contentElement, contentElement,
siblings; siblings;
@ -95,7 +93,7 @@ function doFancyExpensiveTabThings(){
for(var m = 0; m < k; m++){ for(var m = 0; m < k; m++){
removeClass(tabList[m].getElementsByTagName('a')[0], "active"); removeClass(tabList[m].getElementsByTagName('a')[0], "active");
} }
addClass(tab, "active"); addClass(this, "active");
contentElement = document.getElementById(contentLocation.substr(1)); contentElement = document.getElementById(contentLocation.substr(1));
addClass(contentElement, "active"); addClass(contentElement, "active");
@ -108,8 +106,8 @@ function doFancyExpensiveTabThings(){
} }
} }
return false; return false;
}).call(event.target || event.srcElement, event);
}, false); }, false);
})();
} }
} }
} }